feat: crash if sessions directory missing after init - #102
Merged
Conversation
Move mkdir from saveSession() to ensureSessionsDir() init function. - Create ensureSessionsDir() in src/session/index.js for one-time init - Simplify saveSession() to pure writeFile with no mkdir/stat - Shutdown handler propagates saveSession errors as fatal - Add comprehensive tests for all new behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move session directory creation from
saveSession()to a one-time init function. If the sessions directory disappears after init,saveSession()throws and shutdown handlers treat it as fatal (crash with exit code 1).Type of Change
Testing
All 955 tests pass including 5 new tests:
ensureSessionsDircreates directory when missingensureSessionsDirreturns successfully when directory already existssaveSessionwrites file successfully when directory existssaveSessionpropagates writeFile errors unhandledhandleShutdownre-throws errors fromsaveSessionCoverage
ensureDir.js: 100% line, 100% branch, 100% function)Checklist
npm run lintpassesThreat Model Considerations