docs: add config-set-tool change proposal - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the
config-set-toolchange: extracts:config setconfig mutation logic fromsrc/config/loader.jsinto a dedicatedsrc/config/mutate.jsmodule, and wires it into a new set skill tool.Commits
a0f7f45)aa4e9ee):config setcommand path parsing and missing setValue wiring (881f5fb)a2b1ec4)c38c9ab)6fe4ef0)Changes
src/config/mutate.js— self-contained mutator module exporting:parseValue(str)— boolean/number/string coercionassignPath(obj, path, value)— dot-path mutation with intermediate object creation and depth limit (5)applyDotPathMutation(config, dotPath, valueStr)— full pipeline (parse → clone → assign → validate)src/config/loader.js— importsapplyDotPathMutationfrom mutate.js,setConfigValuecallsapplyDotPathMutationthensaveConfigtests/unit/config/mutate.test.js— 16 tests for all mutator exportstests/unit/config.test.js— removed duplicate mutation engine testsreplace-assistant-label-with-namechangeTests
Type of Change
Testing
npm run test— all tests passnpm run coverage— coverage.txt regenerated, 100% coverage maintainednpm run lint— passes cleanCoverage
Checklist
npm run lintpasses