fix: ensure stdout is string before trim in execFile results - #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix recurring `stdout.trim is not a function` error in the searchFiles tool (and session_search). The `execFile` call can return stdout as a Buffer in edge cases (timeouts, encoding mismatches, process kills) even when `encoding: 'utf-8'` is specified. Coerce stdout to string via `String()` before calling `.trim()`.
Type of Change
Testing
All 1133 tests pass. The fix is a defensive coercion — `String()` is a no-op if stdout is already a string, and safely converts a Buffer to its UTF-8 representation otherwise.
Coverage
Checklist