fix: remove DEFAULT_MAX_RESULTS cap from reflection tool - #772
Merged
Conversation
Process every session within the date window — the cap was halting the scan prematurely, losing signal from older sessions that still fall within the window.
The cap was removed — all sessions within the window are now processed. Updated the test to expect all 55 sessions instead of capping at 50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the hardcoded
DEFAULT_MAX_RESULTS = 50cap fromsrc/tools/reflection.js. The reflection tool now processes every session within the date window instead of stopping at 50 files.What Changed
DEFAULT_MAX_RESULTS = 50constantlines.slice(0, DEFAULT_MAX_RESULTS)— all sessions within the window are now processedWhy
The cap was halting the scan prematurely. We never know how many scheduled tasks a user has that generate sessions — we need to process every session within the time window to find signal. Limiting to 50 files means older sessions within the window are silently skipped, losing potentially important reflection data.
Impact
src/tools/reflection.js— removed cap, processes all sessions in window