fix: escape -- flags in process tool commands - #846
Merged
Conversation
The shell command parser intercepts -- and treats it as a parameter delimiter, causing schema validation failures for commands like 'gh pr list --head docs/foo --base main'. Escape -- sequences before passing to the shell to prevent premature parsing.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
processtool's shell command parser rejects commands containing--flags (e.g.,--head,--base,--json). The parser interprets--as tool parameter delimiters rather than shell argument markers, causing schema validation failures.This fix escapes
--sequences to\-\-before passing commands to the shell, preventing premature parsing while preserving the original command semantics.Type of Change
Testing
--flags now pass through correctly (e.g.,gh pr list --head docs/foo --base main --state open)Coverage
Checklist
npm run lintpassesCloses #845