feat: Require service-name as input #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2025 15:51
Move service-name to the top of required input validations since it's now a required parameter. This provides faster feedback to users if the service name is missing. Changes: - Read and validate service-name first among required inputs - Remove duplicate service-name declarations - Fix test mocks that had duplicate service-name entries - All 17 tests passing
Move service-name to be the first input in action.yml since it's now a required parameter. This makes the action.yml structure consistent with the validation order in index.js. Changes: - Move service-name from 'Service identification' section to top - Place it as the first required input - Simplify description to match index.js comment - All 17 tests passing
omkhegde
approved these changes
Nov 25, 2025
amazreech
reviewed
Nov 25, 2025
| core.info('Checking if service exists...'); | ||
| const describeCommand = new DescribeServicesCommand({ | ||
| cluster: clusterName, | ||
| services: [serviceName] |
amazreech
reviewed
Nov 25, 2025
| core.info('Service does not exist, will create new service'); | ||
| } | ||
| } catch (error) { | ||
| if (error.name === 'ServiceNotFoundException' || error.name === 'ClusterNotFoundException') { |
There was a problem hiding this comment.
Doesn't look like ServiceNotFoundException is ever thrown: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_DescribeServices.html
amazreech
reviewed
Nov 25, 2025
| } else { | ||
| throw error; | ||
| core.info('Service exists but is INACTIVE, will create new service'); | ||
| } |
There was a problem hiding this comment.
Do we want to handle the case where service is in DRAINING state here? Prolly an error if a service is DRAINING
https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_Service.html#ECS-Type-Service-status
s3cube
added a commit
that referenced
this pull request
Nov 26, 2025
In this PR:
Requiring the serviceName on the input since the GitHub Action does not store state, and would break if we had to re-use it across requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: