Add support for Deployment Monitoring #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
November 26, 2025 15:50
Add GitHub Actions workflow to test ECS Express service deployment. Changes: - Copy test-action.yml from feature/express-service-deployment - Update to use service-name parameter (required) - Configure to trigger on feature/integration-tests branch - Test deployment with public nginx image - Display service ARN, endpoint, and status outputs
Remove status output line as it's not currently provided by the action.
For testing, use the source index.js file directly instead of requiring a built dist folder.
- Build the action using ncc to create bundled dist/index.js - Remove dist/ from .gitignore so it can be committed - Revert action.yml to use dist/index.js as entry point GitHub Actions require the dist folder to be committed.
… timeout to 15 minutes
…mentArn correctly
amazreech
reviewed
Nov 26, 2025
| // Check if service is ACTIVE | ||
| if (statusCode === 'ACTIVE') { | ||
| if (!serviceActive) { | ||
| serviceActive = true; |
There was a problem hiding this comment.
I might have missed this, where do we use this serviceActive, or do we plan to use it in follow up CRs??
Contributor
Author
There was a problem hiding this comment.
My plan is to potentially add something around the catch block that mentions the service isn't active in edge cases
omkhegde
reviewed
Nov 26, 2025
|
|
||
| // Create or update the service | ||
| let response; | ||
| let deploymentStartTime; |
There was a problem hiding this comment.
this can be just let deploymentStartTime = new Date() ?
omkhegde
reviewed
Nov 26, 2025
|
|
||
| try { | ||
| // Step 1: Check service status using DescribeExpressGatewayService | ||
| const describeServiceCommand = new DescribeExpressGatewayServiceCommand({ |
There was a problem hiding this comment.
we dont need to call describeGWService every time, right? This can happen before the while(true)?
Contributor
Author
There was a problem hiding this comment.
Good point, fixing in the next one
omkhegde
approved these changes
Nov 26, 2025
amazreech
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: