fix: improve timeout handling for long-running CloudFormation stacks#163
Merged
kddejong merged 1 commit intoaws-actions:developfrom Jan 21, 2026
Merged
fix: improve timeout handling for long-running CloudFormation stacks#163kddejong merged 1 commit intoaws-actions:developfrom
kddejong merged 1 commit intoaws-actions:developfrom
Conversation
- Change default timeout from 12 hours to 5h50m (safe for GitHub Actions 6-hour limit) - Make timeout-in-minutes parameter functional for waiter timeout (not just CloudFormation API) - Add graceful timeout handling with warning instead of failure - Return stack ID on timeout so users can monitor progress in AWS Console - Add unit tests for timeout behavior Fixes aws-actions#150 - RDS Aurora and other long-running deployments will now exit gracefully with a warning instead of timing out and failing after 6 hours.
chrisqm-dev
approved these changes
Jan 21, 2026
| { StackName: stackName } | ||
| ) | ||
| try { | ||
| await waitUntilStackOperationComplete( |
There was a problem hiding this comment.
Did we want to add a the stack status inside the waitUntilStackOperationComplete logs?
There was a problem hiding this comment.
Disregard:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.