Skip to content

Conversation

@FunctionalWorm
Copy link

Issue #, if available: #489

Description of changes:

This is @chenrui333's work with its conflicts resolved .
Original PR: #413

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@magnetikonline magnetikonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@FunctionalWorm
Copy link
Author

@peterwoodworth If you have write access to this repo, would you be able to review this for us? Thanks.

@xmunoz
Copy link

xmunoz commented Oct 12, 2022

Please merge this. I'm starting to get warnings in Github Actions for depending on this workflow.

@IdanYaffe
Copy link

Would appreciate it if that could be merged.

@renperez-cpi
Copy link

any update on this? hopefully can merge this soon

@peterwoodworth
Copy link
Contributor

Thanks for the contribution @FunctionalWorm.

We can't merge this at this time unfortunately. See this comment for more information on the plan to update to Node 16, and please refer to that thread for further updates and concerns about this topic.

I will reopen this PR and merge it if it is possible for us to use this PR to perform the upgrade, however I'm pretty doubtful that will end up being possible.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants