Add design tokens #2021
Add design tokens #2021
Conversation
🦋 Changeset detectedLatest commit: 01a1a67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The theme example for the collection primitive will be added to the docs as part of #1947 once these tokens have been merged in. |
dbanksdesign
left a comment
dbanksdesign
left a comment
There was a problem hiding this comment.
Just a few minor comments/questions, but overall looks good!
|
This pull request introduces 1 alert when merging 3411db7 into b1f9e53 - view on LGTM.com new alerts:
|
dbanksdesign
left a comment
dbanksdesign
left a comment
There was a problem hiding this comment.
Conditional approval, I think just the example needs a one line update
| components: { | ||
| searchfield: { | ||
| color: { value: 'red' }, | ||
| search: { |
There was a problem hiding this comment.
I think this should be button: { right? Looking at the searchField.ts file below
There was a problem hiding this comment.
thanks that has been updated to button
reesscot
left a comment
reesscot
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
4 participants
Description of changes
Add new design tokens to collection and searchfield primitives. Previously these two primitives had no design tokens so they couldn't be targeted for theming. This pull request adds a few basic tokens
Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.