Allow external use of write_settings#386
Conversation
|
The test failure reported by Travis is also failing in the master branch and is not introduced by this PR. I'll rebase when it's fixed. |
Fix in #388 |
|
I can't think of/remember a reason not to do this, but I also can't figure out why we didn't do this in the first place - and there must of been a reason for us to go out of our way to not have |
stilvoid
force-pushed
the
allow-write-settings
branch
from
3d1ee5c to
316cb75
Compare
johnttompkins
left a comment
johnttompkins
left a comment
There was a problem hiding this comment.
Looks good. I think previously we just didn't have a use for language in the project other than loading the plugin on subsequent commands.
|
Yeah, I really can't remember. Oh well, ship it :D |
3 participants
Issue #, if available: N#A
Description of changes: Allows plugins to call
write_settingson the project. We need this in the Go plugin as we're intending to store plugin version information in.rpdk-config. See aws-cloudformation/cloudformation-cli-go-plugin#115By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.