Use PEP451 loader to work around pytest/jinja2 disagreements (#387)#388
Merged
tobywf merged 3 commits intoJan 30, 2020
Merged
Conversation
rjlohan
approved these changes
Jan 30, 2020
tobywf
approved these changes
Jan 30, 2020
Contributor
|
Possibly it was this commit: pallets/jinja#1113 This seems to fix the lower pytest version we were needing to use (pytest-dev/pytest#5392), this was always a bit hacky it seems. I don't quite understand in which cases The only other things I did was split the inline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 387
Description of changes: Work around update to Jinja2 that breaks pytest's mangling of module loaders.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.