fix(cached-node-modules): read node-version when building the cache key - #265
Merged
Conversation
v1.5.0 renamed the input from nodeVersion to node-version but left the cache key reading the old name, so the version was always empty and every Node.js matrix cell shared one cache per lockfile. Closes #264
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.5.0 renamed the
cached-node-modulesinput fromnodeVersiontonode-versionbut left the cache key reading the old name.inputs.nodeVersionevaluates to an empty string, so every key is-node-modules-<lockfile hash>and all Node.js matrix cells share onenode_modulescache per lockfile. This restores the version prefix so each Node.js version gets its own cache, as the input's description promises.Changes
inputs.node-versioninstead ofinputs.nodeVersionwhen building theactions/cachekey.Existing caches are invalidated once, since the key shape changes back to
<version>-node-modules-<hash>.Issue number: closes #264
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.