Skip to content

Conversation

@mdesousa
Copy link
Contributor

@mdesousa mdesousa commented Oct 13, 2025

Summary

Fixes #4634


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Oct 13, 2025
@boring-cyborg boring-cyborg bot added the idempotency This item relates to the Idempotency Utility label Oct 13, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2025

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@svozza
Copy link
Contributor

svozza commented Oct 13, 2025

Thanks for the PR. Can you add the acknowledgement text into your issue, just paste it at the bottom:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Also, is there a way to have a unit test for when the value is null/undefined. Would be nice to be able to guard against regressions here for a bug that causes a runtime exception.

@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Oct 13, 2025
@pull-request-size pull-request-size bot added size/S PR between 10-29 LOC and removed size/XS PR between 0-9 LOC labels Oct 13, 2025
@mdesousa
Copy link
Contributor Author

hi @svozza unit test and disclamer added 👍

@sonarqubecloud
Copy link

@svozza
Copy link
Contributor

svozza commented Oct 13, 2025

LGTM. Thanks a lot!

@svozza svozza merged commit 5dab224 into aws-powertools:main Oct 13, 2025
34 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2025

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

idempotency This item relates to the Idempotency Utility size/S PR between 10-29 LOC tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: makeHandlerIdempotent error handler throws "Cannot read properties of undefined"

2 participants