Skip to content

fix(idempotency): add null check for idempotencyHandler before calling handleMiddyOnError #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2025
Merged

fix(idempotency): add null check for idempotencyHandler before calling handleMiddyOnError #4643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d817ed1
fix(idempotency): add null check for idempotencyHandler before callin…
mdesousa Oct 13, 2025
42d1195
Merge branch 'main' into main
svozza Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/idempotency/src/middleware/makeHandlerIdempotent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ const makeHandlerIdempotent = (
}
const idempotencyHandler =
getIdempotencyHandlerFromRequestInternal(request);
await idempotencyHandler.handleMiddyOnError();
await idempotencyHandler?.handleMiddyOnError();
};

return {
Expand Down
22 changes: 22 additions & 0 deletions packages/idempotency/tests/unit/makeIdempotent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,28 @@ describe('Function: makeIdempotent', () => {
expect(deleteRecordSpy).toHaveBeenCalledWith(event);
});

it('handles an execution that throws an early middleware error (middleware)', async () => {
// Prepare
const handler = middy(fnSuccessfull)
.use({ before: fnError })
.use(makeHandlerIdempotent(mockIdempotencyOptions));
const saveInProgressSpy = vi.spyOn(
mockIdempotencyOptions.persistenceStore,
'saveInProgress'
);
const deleteRecordSpy = vi.spyOn(
mockIdempotencyOptions.persistenceStore,
'deleteRecord'
);

// Act && Assess
await expect(handler(event, context)).rejects.toThrowError(
'Something went wrong'
);
expect(saveInProgressSpy).toHaveBeenCalledTimes(0);
expect(deleteRecordSpy).toHaveBeenCalledTimes(0);
});

it.each([
{
type: 'wrapper',
Expand Down
Loading