generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 180
feat(parser): fix DynamoDBStreamChangeRecordSchema.dynamodb type #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in [^1], this helps avoid conflict when referring to schemas and inferred schema types in the same file. We alias the exports to avoid breaking third party imports. [^1]: aws-powertools#4797 (comment)
Before:
// z.infer<typeof DynamoDBStreamChangeRecordSchema>
dynamodb: {
Keys: Record<string, Record<string, any>>;
SizeBytes: number;
ApproximateCreationDateTime?: number | undefined;
NewImage?: Record<string, any> | undefined;
OldImage?: Record<string, any> | undefined;
};
After:
dynamodb: {
Keys: Record<string, Record<string, any>>;
SequenceNumber: string;
SizeBytes: number;
StreamViewType: "NEW_IMAGE" | "OLD_IMAGE" | "NEW_AND_OLD_IMAGES" | "KEYS_ONLY";
ApproximateCreationDateTime?: number | undefined;
NewImage?: Record<string, any> | undefined;
OldImage?: Record<string, any> | undefined;
} | {
Keys: Record<string, Record<string, any>>;
SizeBytes: number;
ApproximateCreationDateTime?: number | undefined;
NewImage?: Record<...> | undefined;
OldImage?: Record<...> | undefined;
};
This converts `unmarshallDynamoDBTransform` to a generic function
and specifies the expected type for both usages.
|
benthorner
commented
Nov 25, 2025
benthorner
commented
Nov 25, 2025
svozza
approved these changes
Nov 25, 2025
Contributor
|
Nice ork @benthorner! LGTM. |
Contributor
Author
|
Thanks for taking a look @svozza! I notice the CI seems to be a bit stuck - anything I can help with? |
Contributor
|
Looks like @sdangol got in before me! All sorted @benthorner, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
Changes
This fixes a DynamoDB Stream record Zod schema typing issue.
Before:
After:
The "before" type is preserved for the Kinesis-only version of the
schema. As part of this change, we internally suffix
Schemaforall properties in
schemas/dynamodb.ts, which unblocks namingsome types to support the main fix - see the first commit.
Issue number: closes #4797
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.