Skip to content

style: remove useAwait linting rule#5146

Merged
dreamorosi merged 2 commits intomainfrom
chore/remove-useAwait-rule
Mar 30, 2026
Merged

style: remove useAwait linting rule#5146
dreamorosi merged 2 commits intomainfrom
chore/remove-useAwait-rule

Conversation

@dreamorosi
Copy link
Copy Markdown
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR removes the useAwait linting rule from the project because as discussed in the linked issue, it only added unneeded overhead. The PR also removes most - if not all - the setTimeout and Promise.resolve occurrences that were added because of this rule.

Finally, as part of working on the PR I ran npm run lint:fix on the project and several export orders changed as result. Similarly, I ran npm audit fix to remove a few CVEs from the dev environment rather than waiting for Dependabot to pick things up.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #5144


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from svozza March 30, 2026 06:04
@dreamorosi dreamorosi self-assigned this Mar 30, 2026
@pull-request-size pull-request-size Bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Mar 30, 2026
@sonarqubecloud
Copy link
Copy Markdown

@dreamorosi
Copy link
Copy Markdown
Contributor Author

The Dependency Review CI check fails because of the yaml package having GHSA-48c2-rrv3-qjmp.

The package comes from multiple libs belonging to AWS CDK:

npm ls yaml
aws-lambda-powertools-typescript@0.0.1 /Users/aamorosi/Codes/aws-lambda-powertools-typescript
├─┬ @aws-lambda-powertools/testing-utils@2.32.0 -> ./packages/testing
│ ├─┬ @aws-cdk/toolkit-lib@1.19.1
│ │ └── yaml@1.10.3
│ └─┬ aws-cdk-lib@2.245.0
│   └── yaml@1.10.3
├─┬ lint-staged@16.4.0
│ └── yaml@2.8.3
├─┬ typedoc@0.28.18
│ └── yaml@2.8.3 deduped
└─┬ vitest@4.1.2
  └─┬ vite@8.0.3
    └── yaml@2.8.3 deduped

I tried manually updating them but nothing changed - since they're not related to this PR and are development dependencies, I'd recommend merging the PR anyway even though I don't like having a failing CI while doing it.

@dreamorosi dreamorosi merged commit fe1e545 into main Mar 30, 2026
49 of 50 checks passed
@dreamorosi dreamorosi deleted the chore/remove-useAwait-rule branch March 30, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL PRs between 500-999 LOC, often PRs that grown with feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: disable useAwait biome lint rule

2 participants