Merged
Conversation
|
Contributor
Author
|
The Dependency Review CI check fails because of the The package comes from multiple libs belonging to AWS CDK: npm ls yaml
aws-lambda-powertools-typescript@0.0.1 /Users/aamorosi/Codes/aws-lambda-powertools-typescript
├─┬ @aws-lambda-powertools/testing-utils@2.32.0 -> ./packages/testing
│ ├─┬ @aws-cdk/toolkit-lib@1.19.1
│ │ └── yaml@1.10.3
│ └─┬ aws-cdk-lib@2.245.0
│ └── yaml@1.10.3
├─┬ lint-staged@16.4.0
│ └── yaml@2.8.3
├─┬ typedoc@0.28.18
│ └── yaml@2.8.3 deduped
└─┬ vitest@4.1.2
└─┬ vite@8.0.3
└── yaml@2.8.3 dedupedI tried manually updating them but nothing changed - since they're not related to this PR and are development dependencies, I'd recommend merging the PR anyway even though I don't like having a failing CI while doing it. |
svozza
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Changes
This PR removes the
useAwaitlinting rule from the project because as discussed in the linked issue, it only added unneeded overhead. The PR also removes most - if not all - thesetTimeoutandPromise.resolveoccurrences that were added because of this rule.Finally, as part of working on the PR I ran
npm run lint:fixon the project and several export orders changed as result. Similarly, I rannpm audit fixto remove a few CVEs from the dev environment rather than waiting for Dependabot to pick things up.Issue number: closes #5144
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.