Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@rkilpadi
Copy link
Contributor

@rkilpadi rkilpadi commented Jul 19, 2022

Description

  • Added Chef script to enable slurmrestd on a head node.
  • Configured slurm.conf to enable JWT authentication.
  • Automated JWT token generation.
  • Configured nginx to allow HTTPS calls to the slurm REST API.
  • Added Slurm REST API custom script to pcluster manager.

How Has This Been Tested?

  • Manually created clusters and ran curl commands from my local machine.

References

Work in Progress

  • slurmdb calls to api do not work, but this is not needed for job submission.
  • Still need to add support for different OSes (currently only works on alinux).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@tmscarla tmscarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some comments, mostly clarifying questions.

Suggestion: in this PR you are adding files (nginx, chef and bash script), enhancing documentation and modifying a frontend React component. These changes could have been separated into multiple micro-commits.

Small, self-contained commits are easier to review, and in the context of a PR they tell a story of incremental changes. This can be really useful, drastically reducing the time spent in diving deep into the code in the next months, years, decades... :)

@rkilpadi rkilpadi force-pushed the main branch 4 times, most recently from 601f07e to 117b0f5 Compare August 10, 2022 20:14
@mendaomn mendaomn changed the base branch from main to enable-slurm-rest-api August 22, 2022 09:27
@mtfranchetto mtfranchetto merged commit d80a917 into aws-samples:enable-slurm-rest-api Aug 25, 2022
mtfranchetto added a commit that referenced this pull request Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants