This repository was archived by the owner on Mar 13, 2023. It is now read-only.
generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 27
Enable Slurm REST API #197
Merged
mtfranchetto
merged 3 commits into
aws-samples:enable-slurm-rest-api
from
rkilpadi:main
Aug 25, 2022
Merged
Enable Slurm REST API #197
mtfranchetto
merged 3 commits into
aws-samples:enable-slurm-rest-api
from
rkilpadi:main
Aug 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmscarla
reviewed
Jul 20, 2022
tmscarla
reviewed
Jul 20, 2022
Contributor
tmscarla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave some comments, mostly clarifying questions.
Suggestion: in this PR you are adding files (nginx, chef and bash script), enhancing documentation and modifying a frontend React component. These changes could have been separated into multiple micro-commits.
Small, self-contained commits are easier to review, and in the context of a PR they tell a story of incremental changes. This can be really useful, drastically reducing the time spent in diving deep into the code in the next months, years, decades... :)
sean-smith
reviewed
Jul 20, 2022
3010e50 to
7363390
Compare
601f07e to
117b0f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
References
Work in Progress
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.