Skip to content
This repository was archived by the owner on Mar 13, 2023. It is now read-only.

Conversation

@rkilpadi
Copy link
Contributor

@rkilpadi rkilpadi commented Aug 2, 2022

Description

Added an option to submit jobs by file upload or manual entry through a code editor. This is a proof of concept for my Slurm REST API script. Jobs entered through this method are submitted through the Slurm API rather than SSM.

Screen Shot 2022-08-16 at 6 35 17 PM

Changes

  • Added a new component JobField to simplify JobSubmitDialog.
  • Added a new API endpoint to proxy requests to the Slurm REST API.
  • Added new script submit option, which is only selectable when a cluster has the Slurm REST API Custom Bootstrap Action enabled. (waiting on Move code for getting list of custom bootstrap actions to util.tsx #227)
  • Fixed a couple bugs/issues along the way
    • State did not clear when user inputted and then deleted a job property, which caused the job to fail
    • Error messages were never cleared
    • Refactored SubmitJob endpoint to return a Promise
    • Use translations in JobSubmitDialog.tsx

How Has This Been Tested?

Manually submitted jobs with different properties and checked the request submitted to the Slurm API.

References

#197
https://slurm.schedmd.com/rest_api.html#slurmV0038SubmitJob

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tmscarla tmscarla self-requested a review August 3, 2022 09:45
@rkilpadi rkilpadi force-pushed the frontend branch 8 times, most recently from 3dfea99 to 68cb021 Compare August 5, 2022 19:00
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 10, 2022
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 11, 2022
Refactor JobSubmitDialog.tsx and use translation
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 11, 2022
Refactor code and throw error when job is empty
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 11, 2022
Refactor code and use translation
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 11, 2022
Refactor code in JobSubmitDialog.tsx and use translation
@rkilpadi rkilpadi force-pushed the frontend branch 3 times, most recently from b6dff73 to eb0ea26 Compare August 16, 2022 18:53
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 16, 2022
Remove useEffect hook in JobSubmitDialog and add useCallback hooks
@mendaomn mendaomn changed the base branch from main to job-submission-manual-script-entry August 17, 2022 08:42
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 23, 2022
Refactor code and throw error when job is empty
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 23, 2022
Refactor code in JobSubmitDialog.tsx and use translation
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 23, 2022
Remove useEffect hook in JobSubmitDialog and add useCallback hooks
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 23, 2022
Refactor code and throw error when job is empty
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 23, 2022
Refactor code in JobSubmitDialog.tsx and use translation
rkilpadi added a commit to rkilpadi/pcluster-manager that referenced this pull request Aug 23, 2022
Remove useEffect hook in JobSubmitDialog and add useCallback hooks
@rkilpadi rkilpadi force-pushed the frontend branch 4 times, most recently from 7a2dfce to 26d5187 Compare August 23, 2022 22:16
@mtfranchetto mtfranchetto merged commit b00b5a2 into aws-samples:job-submission-manual-script-entry Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants