This repository was archived by the owner on Mar 13, 2023. It is now read-only.
Move Slurm memory based scheduling from 'HeadNode' to 'Queues' wizard section #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfranchetto
suggested changes
Oct 19, 2022
tmscarla
force-pushed
the
tsscarla/move-memory-based
branch
from
a206bba to
eb37ba5
Compare
mendaomn
reviewed
Oct 19, 2022
Comment on lines
78
to
80
| <a href="#" className={styles.info}> | ||
| {t('wizard.queues.slurmMemorySettings.container.info')} | ||
| </a> |
Contributor
There was a problem hiding this comment.
We could simply leverage the provided Info link
It's not recommended to use them to trigger popovers (source), but for the time being this is the solution we should stick with (we'll implement the help panel in the future)
In general I'd avoid using custom implementations, but rather ping our designer of reference with a suggestion taken from the design system
tmscarla
force-pushed
the
tsscarla/move-memory-based
branch
from
eb37ba5 to
397a77c
Compare
tmscarla
force-pushed
the
tsscarla/move-memory-based
branch
from
397a77c to
4fd20b1
Compare
| } | ||
| > | ||
| <SpaceBetween size={'s'} direction={'vertical'}> | ||
| <div |
Contributor
There was a problem hiding this comment.
question: is this div needed? I guess it can be safely removed
mtfranchetto
approved these changes
Oct 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the UX refactoring of ParallelCluster Manager, this PR aims at moving the 'Enable Slurm Memory Based Scheduling' toggle from the HeadNode to the Queues wizard section, in a new, dedicated box.
With PC 3.3, multiple
InstanceTypesper queues have been introduced. We need to disableSlurm Memory Based Schedulingin case of multiple instance types have been selected. This issue will be handled in a dedicated PR.Changelog entry
How Has This Been Tested?
References
PR Quality Checklist
i18nsolution instead (see here)npm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.