This repository was archived by the owner on Mar 13, 2023. It is now read-only.
generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 27
Move Slurm memory based scheduling from 'HeadNode' to 'Queues' wizard section #324
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
86a03d0
Add SlurmMemorySettings component
tmscarla 3018a66
Move 'Enable Slurm Memory Based Scheduling' toggle from HeadNode to Q…
tmscarla 1338344
Implement i18n strings for Slurm Memory Based Scheduling
tmscarla 4fd20b1
Restore Slurm Memory Based scheduling info tooltip and fix alert message
tmscarla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
frontend/src/old-pages/Configure/SlurmMemorySettings.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"). You may not use this file except in compliance | ||
| // with the License. A copy of the License is located at | ||
| // | ||
| // http://aws.amazon.com/apache2.0/ | ||
| // | ||
| // or in the "LICENSE.txt" file accompanying this file. This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES | ||
| // OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import * as React from 'react' | ||
| import {Trans, useTranslation} from 'react-i18next' | ||
| import { | ||
| Container, | ||
| Header, | ||
| Alert, | ||
| Toggle, | ||
| SpaceBetween, | ||
| Popover, | ||
| Link, | ||
| } from '@awsui/components-react' | ||
| import {setState, getState, useState, clearState} from '../../store' | ||
|
|
||
| function SlurmMemorySettings() { | ||
| const {t} = useTranslation() | ||
| const [infoAlertVisible, setInfoAlertVisible] = React.useState(false) | ||
| const slurmSettingsPath = [ | ||
| 'app', | ||
| 'wizard', | ||
| 'config', | ||
| 'Scheduling', | ||
| 'SlurmSettings', | ||
| ] | ||
| const memoryBasedSchedulingEnabledPath = [ | ||
| ...slurmSettingsPath, | ||
| 'EnableMemoryBasedScheduling', | ||
| ] | ||
| const memoryBasedSchedulingEnabled = useState( | ||
| memoryBasedSchedulingEnabledPath, | ||
| ) | ||
|
|
||
| const toggleMemoryBasedSchedulingEnabled = () => { | ||
| const setMemoryBasedSchedulingEnabled = !memoryBasedSchedulingEnabled | ||
| if (setMemoryBasedSchedulingEnabled) | ||
| setState( | ||
| memoryBasedSchedulingEnabledPath, | ||
| setMemoryBasedSchedulingEnabled, | ||
| ) | ||
| else { | ||
| clearState(memoryBasedSchedulingEnabledPath) | ||
| if (Object.keys(getState([...slurmSettingsPath])).length === 0) | ||
| clearState([...slurmSettingsPath]) | ||
| } | ||
| } | ||
|
|
||
| return ( | ||
| <Container | ||
| header={ | ||
| <Header variant="h2"> | ||
| <SpaceBetween size="xs" direction="horizontal"> | ||
| {t('wizard.queues.slurmMemorySettings.container.title')} | ||
| <Popover | ||
| dismissButton={true} | ||
| position="right" | ||
| size="small" | ||
| triggerType="custom" | ||
| content={ | ||
| <Trans i18nKey="wizard.queues.slurmMemorySettings.container.help"> | ||
| <a | ||
| rel="noopener noreferrer" | ||
| target="_blank" | ||
| href="https://slurm.schedmd.com/cgroup.conf.html#OPT_ConstrainRAMSpace" | ||
| ></a> | ||
| </Trans> | ||
| } | ||
| > | ||
| <Link variant="info"> | ||
| {t('wizard.queues.slurmMemorySettings.container.info')} | ||
| </Link> | ||
| </Popover> | ||
| </SpaceBetween> | ||
| </Header> | ||
| } | ||
| > | ||
| <SpaceBetween size={'s'} direction={'vertical'}> | ||
| <div | ||
| key="memory-based-scheduling-enabled" | ||
| style={{ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| }} | ||
| > | ||
| <Toggle | ||
| checked={memoryBasedSchedulingEnabled} | ||
| onChange={toggleMemoryBasedSchedulingEnabled} | ||
| > | ||
| <Trans i18nKey="wizard.queues.slurmMemorySettings.toggle.label" /> | ||
| </Toggle> | ||
| </div> | ||
| <Alert | ||
| onDismiss={() => setInfoAlertVisible(false)} | ||
| visible={infoAlertVisible} | ||
| dismissAriaLabel={t( | ||
| 'wizard.queues.slurmMemorySettings.info.dismissAriaLabel', | ||
| )} | ||
| dismissible | ||
| header={t('wizard.queues.slurmMemorySettings.info.header')} | ||
| > | ||
| {t('wizard.queues.slurmMemorySettings.info.body')} | ||
| </Alert> | ||
| </SpaceBetween> | ||
| </Container> | ||
| ) | ||
| } | ||
|
|
||
| export {SlurmMemorySettings} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is this
divneeded? I guess it can be safely removed