fix(runtime): defer invoke required flag validation - #1876
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1876 +/- ##
=========================================
Coverage 95.85% 95.86%
=========================================
Files 198 198
Lines 9341 9352 +11
=========================================
+ Hits 8954 8965 +11
Misses 387 387 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Hweinstock
approved these changes
Jul 30, 2026
| handle: async (ctx, flags) => { | ||
| if (flags.id === undefined) { | ||
| throw new InputValidationError("required option '--id <id>' not specified", { | ||
| exitCode: ExitCode.USAGE, |
Contributor
There was a problem hiding this comment.
I didn't realize that 2 was the standard for validation exceptions. Should we make this the default on the input validation error class? (could be a follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--idand--payloadas optional at the Commander boundaryruntime invokereaches the existing TUI middleware and empty payloads remain validTesting
bun test src/handlers/runtime/invoke(54 pass)bun test(538 pass)bun run typecheckbun run lint:checkbun run format:checkbun run build