Skip to content

fix: used FormTextInput for endpoint create name - #2211

Merged
nborges-aws merged 1 commit into
refactorfrom
polish/endpoint-create
Sep 3, 2026
Merged

fix: used FormTextInput for endpoint create name#2211
nborges-aws merged 1 commit into
refactorfrom
polish/endpoint-create

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

Update harness endpoint create TUI flow to use FormTextInput - bringing the UX in line with the standard throughout the code base.

Before:
image

After:
image

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): tech debt

Testing

How have you tested the change?

  • bun run test (2961 pass, 0 fail)
  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/s PR size: S label Sep 3, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Sep 3, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 3, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, focused refactor that swaps NameStep's hand-rolled TextInput + error state for the shared FormTextInput, matching what HarnessWizard, project create, and memory record list already do. Behavior is preserved (escape → back, Enter only advances when the pattern matches, help text/error rendered by FormTextInput), and the added test assertion (│❯ production) confirms the bordered input renders with the placeholder.

One minor UX shift worth noting (not blocking): pressing Enter on an empty/invalid name is now a silent no-op instead of surfacing the error text, since FormTextInput only renders the error once value !== "". This matches the established pattern in HarnessWizard, so it's consistent.

No new telemetry needed — this is a UI-only refactor of an existing flow. Nothing to change before merge.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 3, 2026

@notgitika notgitika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I didnt notice this one

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.08%. Comparing base (4d806e8) to head (0052938).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2211      +/-   ##
============================================
- Coverage     97.08%   97.08%   -0.01%     
============================================
  Files           544      544              
  Lines         37869    37861       -8     
============================================
- Hits          36765    36757       -8     
  Misses         1104     1104              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nborges-aws
nborges-aws merged commit d041f01 into refactor Sep 3, 2026
30 of 32 checks passed
@nborges-aws
nborges-aws deleted the polish/endpoint-create branch September 3, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants