fix: used FormTextInput for endpoint create name - #2211
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, focused refactor that swaps NameStep's hand-rolled TextInput + error state for the shared FormTextInput, matching what HarnessWizard, project create, and memory record list already do. Behavior is preserved (escape → back, Enter only advances when the pattern matches, help text/error rendered by FormTextInput), and the added test assertion (│❯ production) confirms the bordered input renders with the placeholder.
One minor UX shift worth noting (not blocking): pressing Enter on an empty/invalid name is now a silent no-op instead of surfacing the error text, since FormTextInput only renders the error once value !== "". This matches the established pattern in HarnessWizard, so it's consistent.
No new telemetry needed — this is a UI-only refactor of an existing flow. Nothing to change before merge.
notgitika
left a comment
There was a problem hiding this comment.
nice! I didnt notice this one
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2211 +/- ##
============================================
- Coverage 97.08% 97.08% -0.01%
============================================
Files 544 544
Lines 37869 37861 -8
============================================
- Hits 36765 36757 -8
Misses 1104 1104 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
Update
harness endpoint createTUI flow to useFormTextInput- bringing the UX in line with the standard throughout the code base.Before:

After:

Type of Change
Testing
How have you tested the change?
bun run test(2961 pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.