chore(help): simplify command indexes - #2219
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2219 +/- ##
=========================================
Coverage 97.04% 97.04%
=========================================
Files 544 544
Lines 37536 37537 +1
=========================================
+ Hits 36428 36429 +1
Misses 1108 1108 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Claude Security Review: no high-confidence findings. (run) |
2ec6da0 to
07e5d89
Compare
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped change that overrides Commander's subcommandTerm so the command index shows just names instead of the full name [options] <args> signature. Behavior:
Usage:line is untouched (still shows[options] [command]), which the test asserts.- Subcommand entries drop
[options], positional args, and the[command]marker on groups.
The test uses real Router/Commander instances and covers the three interesting cases (flags, positional args, nested groups). No mocking concerns, and no telemetry is warranted for a help-formatting change. Nothing blocking — all substantive points were already covered by the prior automated review.
Summary
subcommandTermformatter to show command names onlyUsage:lineThis makes every command index consistent and easier to scan without changing parsing or command-specific help.
Example
Before:
After:
agentcore project remove --helpstill showsUsage: agentcore project remove [options] [resource].Testing
bun test src/router/router.test.tsbun run typecheckbun run lint:checkbun run format:check