fix(update): assert against the active dist-tag, not hardcoded "latest" - #2243
Merged
Conversation
…est" The update handler was changed to pick the npm dist-tag from the local prerelease (rc/preview/latest), but two assertions in update.test.ts still hardcoded "latest", so CI on 1.0.0-rc.1 fails: the handler installs @aws/agentcore@rc while the tests expect @aws/agentcore@latest. Route both assertions through distTag() so the test tracks whichever tag the current version resolves to.
tejaskash
pushed a commit
that referenced
this pull request
Sep 4, 2026
* chore(release): v1.0.0-rc.1 * fix(update): assert against the active dist-tag, not a hardcoded "latest" (#2243) The update handler was changed to pick the npm dist-tag from the local prerelease (rc/preview/latest), but two assertions in update.test.ts still hardcoded "latest", so CI on 1.0.0-rc.1 fails: the handler installs @aws/agentcore@rc while the tests expect @aws/agentcore@latest. Route both assertions through distTag() so the test tracks whichever tag the current version resolves to. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Trirmadura J Ariyawansa <tjariy@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/v1.0.0-rc.1fails insrc/handlers/update/update.test.tsbecause two assertions hardcode thelatestdist-tag, while the handler on this branch now resolves the tag from the local prerelease (rcfor1.0.0-rc.1). Route both assertions throughdistTag()so the test follows whichever tag the current version resolves to.Test plan
bun test src/handlers/update/update.test.ts— 11 pass, 0 fail locally on this branch