Regenerate CRDs with generateEmbeddedObjectMeta flag - #402
Merged
Conversation
…te metadata schema
okankoAMZ
approved these changes
Jul 23, 2026
movence
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #395 (prometheus/k8s dependency bump) included regenerated CRDs that were produced without the Makefile's
CRD_OPTIONS="crd:generateEmbeddedObjectMeta=true", which stripped the embedded ObjectMeta schema (labels,annotations,finalizers,name,namespace) from PVC templatemetadatain the AmazonCloudWatchAgent, DcgmExporter, and NeuronMonitor CRDs.Because those metadata schemas became bare
type: objectwith no properties and nox-kubernetes-preserve-unknown-fields, structural schema pruning would silently strip labels/annotations that users set onvolumeClaimTemplates/ ephemeral volume claim template metadata in their CRs.This PR restores the schema by regenerating via
make manifests(which applies the flag). Pure additions: 3 files, +68 lines, four restored ObjectMeta blocks. No other generated manifests changed.Verification
make manifestsoutput is now stable (re-running produces no diff)