Switch null_resource to external for helm git clone step - #553
Merged
Conversation
TravisStark
approved these changes
Jul 2, 2025
JayPolanco
self-requested a review
July 2, 2025 19:10
JayPolanco
approved these changes
Jul 2, 2025
JayPolanco
reviewed
Jul 2, 2025
| fi | ||
| EOT | ||
| } | ||
| data "external" "clone_helm_chart" { |
Contributor
There was a problem hiding this comment.
Interesting, this is probably better considering they don't recomment using null_resource except a sa last resort
Contributor
|
Do you know why null_resource stopped working? Couldn't find any official documentation of a change |
Contributor
Author
I don't know why this is suddenly failing and suspect that some version bump of either tf itself of plugin might be causing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
helm_releaseis failing by missing cloned helm chartsDescription of changes
null_resourcetoexternalto make sure the completion ofgit clonestep of the chartsLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Run
terraform applylocally