Append customer prometheus scrape configs - #1847
Merged
agarakan merged 3 commits intoSep 5, 2025
Merged
Conversation
TravisStark
approved these changes
Sep 4, 2025
agarakan
force-pushed
the
merge-prom-scrape-configs
branch
from
September 4, 2025 20:17
350726b to
10ad471
Compare
agarakan
force-pushed
the
merge-prom-scrape-configs
branch
from
September 4, 2025 20:24
10ad471 to
210b509
Compare
sky333999
approved these changes
Sep 4, 2025
dricross
reviewed
Sep 5, 2025
chadpatel
pushed a commit
to chadpatel/amazon-cloudwatch-agent
that referenced
this pull request
Mar 19, 2026
Co-authored-by: Akansha Agarwal <agarakan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
When a customer provides prometheus scrape config relabel configs, we should not overwrite them. Additionally, the customer provided config must be processed last, after the default relabel config. This is to retain backwards compatibility given the new labels generated by the OTEL plugin for prometheus file-based service discovery (ECS Observer).
Description of changes
This change detects customer provided relabel configs and appends them to the dynamically configured relabel configs so that they can be processed after
ex:
Customer provides
then the generated relabelConfig must look like this so that the Customer's action on
StartedBydoes not failLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added unit tests to verify customer scrape configs & all unit tests are passing
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.