Skip to content

Improve otel-fork-replace workflow: dynamic component discovery, changelog in PR - #2086

Merged
sky333999 merged 5 commits into
mainfrom
sky333999/contrib-update
Apr 16, 2026
Merged

Improve otel-fork-replace workflow: dynamic component discovery, changelog in PR#2086
sky333999 merged 5 commits into
mainfrom
sky333999/contrib-update

Conversation

@sky333999

@sky333999 sky333999 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Changes to otel-fork-replace workflow

  • Parse go.mod dynamically instead of hardcoding fork components, so the workflow never goes stale when components are added/removed
  • Fix shell syntax bug in commit SHA conditional (missing spaces)
  • Add changelog table to PR description with commit and PR links
  • Run go mod tidy once instead of after every go mod edit
  • Add set -euo pipefail for fail-fast error handling
  • Use repo-local git config instead of global with fragile cleanup
  • Adds a safeguard that aborts if fork components point to multiple distinct SHAs (indicating an intentional pin).

Changes to PR-test workflow

  • Allow a "skip testing" label to be set on the PR to bypass testing and still satisfy GH checks. Should only be used for PRs that do no impact functionality of the agent such as doc updates, workflow file updates etc.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Tested the chunks locally.

Requirements

Before commiting your code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

Integration Tests

To run integration tests against this PR, add the ready for testing label.

…gelog in PR

- Parse go.mod dynamically instead of hardcoding fork components,
  so the workflow never goes stale when components are added/removed
- Fix shell syntax bug in commit SHA conditional (missing spaces)
- Add changelog table to PR description with commit and PR links
- Run go mod tidy once instead of after every go mod edit
- Add set -euo pipefail for fail-fast error handling
- Use repo-local git config instead of global with fragile cleanup
@sky333999
sky333999 requested a review from a team as a code owner April 16, 2026 16:47
Comment thread .github/workflows/otel-fork-replace.yml
Comment thread .github/workflows/otel-fork-replace.yml
@sky333999
sky333999 merged commit efbdfa5 into main Apr 16, 2026
37 of 39 checks passed
@sky333999
sky333999 deleted the sky333999/contrib-update branch April 16, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants