Use query XML for windows events logs - #2201
Merged
Merged
Conversation
jefchien
force-pushed
the
add-windows-events-query-xml
branch
from
July 14, 2026 16:54
7c7b0f9 to
222646a
Compare
sky333999
reviewed
Jul 14, 2026
| } | ||
|
|
||
| func (e eventEntry) receiverHash() string { | ||
| return hash.HashName(fmt.Sprintf("%s\x00%s\x00%v\x00%v", e.channel, e.format, e.eventLevels, e.eventIDs)) |
Contributor
There was a problem hiding this comment.
nit: might wanna sort the levels and then hash
sky333999
previously approved these changes
Jul 14, 2026
sky333999
approved these changes
Jul 14, 2026
TravisStark
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Follow up to #2193. The original PR used OTTL based filtering for event IDs and levels, which didn't work if the format of the event log was XML.
Description of changes
Dependent on the cherry-pick in amazon-contributing/opentelemetry-collector-contrib#598 that adds query XML support to the receiver. This leverages that functionality to be more in-line with the
logs/logs_collected/windows_events.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Built and tested on Windows instance using eventcreate to generate events. The filtering works and now works when sending the logs in XML.
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.