Fix unit test test_profiler_runner that was failing sometimes; updated README. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirelap-amazon
changed the title
gimki
reviewed
Jan 8, 2021
test/unit/test_profiler_runner.py
Outdated
| wait_for(lambda: AgentConfiguration.get().reporting_interval.total_seconds() == 151) | ||
| # sometimes it takes a few milliseconds for the scheduler to be updated with the AgentConfiguration, | ||
| # so let's sleep for 100 ms | ||
| sleep(0.1) |
Contributor
There was a problem hiding this comment.
should we use wait_for instead here?
Contributor
Author
There was a problem hiding this comment.
Good point, I'll update.
gimki
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.