Skip to content

Fix unit test test_profiler_runner that was failing sometimes; updated README. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix unit test test_profiler_runner that was failing sometimes; updated README. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05769a2
Fix unit test test_profiler_runner that was failing sometimes.
mirelap-amazon Jan 8, 2021
e0eb42b
Include link to GitHub in README.md for tracking back from PyPI.
mirelap-amazon Jan 8, 2021
64213b5
Addressed comments - used wait_for(..) instead of sleep(..).
mirelap-amazon Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,17 @@ For more details, check the documentation: https://docs.aws.amazon.com/codeguru/

## How to use it

This package is released to PyPI, so use it as any Python package from PyPI: https://pypi.org/project/codeguru-profiler-agent
This package is being released to PyPI as [codeguru-profiler-agent](https://pypi.org/project/codeguru-profiler-agent), so use it as any Python package from PyPI.

For a demo application that uses this agent, check our [demo application](https://github.com/aws-samples/aws-codeguru-profiler-python-demo-application).

## Release to PyPI
## How to contribute

Check the GitHub repository at [aws/amazon-codeguru-profiler-python-agent](https://github.com/aws/amazon-codeguru-profiler-python-agent).

See [CONTRIBUTING](CONTRIBUTING.md) for details.

## How to release to PyPI

Use the `setup.py` script to create the archive.

Expand All @@ -18,5 +24,5 @@ See [CONTRIBUTING](CONTRIBUTING.md#security-issue-notifications) for more inform

## License

This project is licensed under the Apache-2.0 License.
This project is licensed under the Apache-2.0 License. See [LICENSE](LICENSE) for details.

2 changes: 2 additions & 0 deletions test/unit/test_profiler_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from test.pytestutils import before
from test.help_utils import wait_for
from mock import MagicMock
from time import sleep

from codeguru_profiler_agent.profiler_runner import ProfilerRunner
from codeguru_profiler_agent.profiler_disabler import ProfilerDisabler
Expand Down Expand Up @@ -87,6 +88,7 @@ def test_when_orchestrator_says_no_to_profiler(self):
self.profiler_runner.start()
# still it is safer to wait until the new config has been applied
wait_for(lambda: AgentConfiguration.get().reporting_interval.total_seconds() == 151)
wait_for(lambda: self.profiler_runner.scheduler._get_next_delay_seconds() == 151)

assert self.profiler_runner.scheduler._get_next_delay_seconds() == 151
self.mock_collector.add.assert_not_called()