[AD-1070] Automate Windows Signing Step for GitHub #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update and confirm the build instructions for macOS and Windows Linux is outstanding * Fixed formatting * Update BUILD_INSTRUCTIONS.md * Update macOS DSN configuration * Update test documentation Update the documentation for running Mac tests and updated the saml_authentication_tests to use environment variables. * update_odbc_file * run_tests_mac review changes. * Update test to remove my email and to change to SQL_SUCCESS. * update_relative_paths * added Linux instructions * update based on comments * update_mac_comments * updated mac documentation * update based on comments. * remove odbc.ini The versions from the test directory will be copied during install. Removing. * review changes * Removed merge of odbc-linux.ini and odbc-mac.ini files into one Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
Co-authored-by: Kyle Porter <kylep@bitquilltech.com>
Rework strncpy_null() and strncpy_lower_null() to be more safe
* not treat trailing 0s as truncation * address comments
* update mac_excel steps * remove_img_files * update_windows_files * update based on comments * Update Windows Instructions Updated the export statements to "set" and removed the duplication * update to backslash Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
…tall AT-886 Document yum Install and Fix Installer for Amazon Linux 2
* update_user_documentation Updated the mac_configure_dsn file to refer to the Configuration Options and remove the "sudo" for user DSN. Updated the windows_configure_dsn file to refer to the Configuration options. Updated microsoft_excel_support_mac to provide more information on Excel and AWS Profiles. * update excel for mac documentation * Update microsoft_excel_support_mac.md Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
…md file (#165) Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
* install_ini_files * update installer files * update_linux_path * use TESTS_INI directory * Update linux-build.yml * changed mv to cp * Update mac-build.yml copy ini files instead of moving them. * change filename to mac_configure_dsn.md. Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
* Split the files by OS and cleaned up the README.md file. * Added links for Linux * AT-820. Document SQL_AUTOCOMMIT=OFF * Made fixes based on comments and corrected odbcinst.ini file for Linux * replaced version with [version] * Update README.md * update files * Merge branch 'split_build_instructions' of https://github.com/Bit-Quill/timestream-odbc into split_build_instructions Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
Handle long conversion underflow/overflow according to 32 bit min/max
* update_dsn * change configuration wording * Updated based on comments. * update windows environment variable Co-authored-by: Charlene Solonynka <csolonynka@dremio.com>
…rs (#104) * added error for the execution of queries with parameters
* [AD-859] Performance improvement for ODBC * [AD-859] Performance improvement for ODBC * [AD-859] Fix of MacOS build for missing MongoDB Community.
* [AD-514] Rename and refactor Ignite to DocumentDB. * [AD-514] Attempt fix of MacOS build for missing MongoDB Community. * [AD-514] Attempt fix of MacOS build for missing MongoDB Community. * [AD-514] Attempt fix of MacOS build for missing MongoDB Community. * [AD-514] Improve installation of mongodb community server on MacOS. * [AD-514] Change ignite_test to documentdb_test - code review improvement. * [AD-514] Rename IGNITE* identifiers. * Update src/odbc/include/documentdb/odbc/documentdb_error.h Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * Update src/odbc/include/documentdb/odbc/documentdb_error.h Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-514] Code review improvements. * Update src/odbc/os/win/include/documentdb/odbc/common/dynamic_load_os.h Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-514] Code review improvements. * [AD-514] Code review improvements. * [AD-514] Code review improvements. Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
…about the driver and data source associated with a connection. (#107) * [AD-541] Initial commit for SQLGetInfo support. * [AD-541] More progress on SQLGetInfo support. * [AD-541] More progress on SQLGetInfo support. * [AD-541] All attributes set. * [AD-541] Fix SQL_DBMS_VER test to be independent of variable value. * [AD-541] Make testing user name more flexible. * [AD-541] Fix missing definition for SQL_CVT_GUID. * [AD-541] Fix Linux build for SQLWCHAR. * [AD-541] Attempt fix Linux test for DSN value. * [AD-541] Modify test for SQLGetInfo/SQL_DATA_SOURCE_NAME on Linux. * [AD-541] Add comments for clarity. * [AD-541] Add comments for clarity.
* [AD-845] Update user and password if passed to SQLConnect. * [AD-845] Add tests for SQLConnect. * [AD-845] Refactor Windows-specific code. * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Fix Linux ODBC compile error. * [AD-845] Fix MacOS ODBC compile error. * [AD-845] Attempt to resolve Linux test error for writing to ODBC.INI * [AD-845] Attempt to resolve Linux test error for prefixed text in error message. * [AD-845] Refactor location to ODBC.INI * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Code review suggestions.
* [AD-845] Update user and password if passed to SQLConnect. * [AD-845] Add tests for SQLConnect. * [AD-845] Refactor Windows-specific code. * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Fix Linux ODBC compile error. * [AD-845] Fix MacOS ODBC compile error. * [AD-845] Attempt to resolve Linux test error for writing to ODBC.INI * [AD-845] Attempt to resolve Linux test error for prefixed text in error message. * [AD-845] Refactor location to ODBC.INI * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Code review suggestions. * [AD-864] Improve UI/UX of DSN dialog. * [AD-864] Add/update screen-shots and documentation for new DSN dialog layout. * [AD-864] Correct validation for login timeout to allow zero. * Update src/odbc/os/win/include/documentdb/odbc/system/ui/dsn_configuration_window.h Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * Update src/odbc/os/win/src/system/ui/dsn_configuration_window.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-864] Review comment improvments. User/password handling improvements. * [AD-864] Review comment improvements. Fix rename bug. Improve dialog error handling. * [AD-864] Review comment improvements. Replace tab with spaces. * [AD-864] Review comment improvements. Remove commented code. * [AD-864] Review comment improvements. Use Cmake project version to set the driver version. * [AD-864] Review comment improvements. Set optional invalid values to default. * [AD-864] Review comment improvements. Handle port=0 validation. Improve balloon behaviour. * Update src/odbc/os/win/src/system/ui/custom_window.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-864] Fix identifier name bug. Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
* [AD-845] Update user and password if passed to SQLConnect. * [AD-845] Add tests for SQLConnect. * [AD-845] Refactor Windows-specific code. * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Fix Linux ODBC compile error. * [AD-845] Fix MacOS ODBC compile error. * [AD-845] Attempt to resolve Linux test error for writing to ODBC.INI * [AD-845] Attempt to resolve Linux test error for prefixed text in error message. * [AD-845] Refactor location to ODBC.INI * [AD-845] Attempt to resolve MacOS test error for writing to ODBC.INI * [AD-845] Code review suggestions. * [AD-864] Improve UI/UX of DSN dialog. * [AD-864] Add/update screen-shots and documentation for new DSN dialog layout. * [AD-864] Correct validation for login timeout to allow zero. * Update src/odbc/os/win/include/documentdb/odbc/system/ui/dsn_configuration_window.h Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * Update src/odbc/os/win/src/system/ui/dsn_configuration_window.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-864] Review comment improvments. User/password handling improvements. * [AD-864] Review comment improvements. Fix rename bug. Improve dialog error handling. * [AD-864] Review comment improvements. Replace tab with spaces. * [AD-864] Review comment improvements. Remove commented code. * [AD-864] Review comment improvements. Use Cmake project version to set the driver version. * [AD-864] Review comment improvements. Set optional invalid values to default. * [AD-864] Review comment improvements. Handle port=0 validation. Improve balloon behaviour. * Update src/odbc/os/win/src/system/ui/custom_window.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-898] Initial commit to add appName option on MongoCXX connection. * [AD-864] Fix identifier name bug. * [AD-898] Add unit test. Refactored some code. * [AD-898] Improvements via code review comments. * Update src/odbc-test/src/configuration_test.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * Update src/odbc-test/src/configuration_test.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * [AD-898] Improvements via code review comments. Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
* updated notice file and documentation Co-authored-by: Bruce Irschick <brucei@bitquilltech.com> Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
…han 1. (#114) * [AD-909] Implement row_array_size statement attribute. Fix discovered bugs. * [AD-909] Attempt to resolve MacOS test issues. * [AD-909] Attempt to resolve MacOS test issues. * [AD-909] Attempt to resolve MacOS test issues. * [AD-909] Fix compile error. * [AD-909] Clean-up code. * [AD-876] Code review improvement to add ticket for performance tests. * [AD-876] Code review improvements comments/data types/documentation. * Update src/odbc-test/src/api_robustness_test.cpp Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
* port unable to change log file bug * Update src/markdown/setup/connection-string.md Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * set loglevel error Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
…ction (#118) * adapted all dsn configuration to be used on mongo cxx driver * fixed local test connection and unit tests * [AD-599] Set the allow_invalid_certificates option. * Apply suggestions from code review Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Bruce Irschick <brucei@bitquilltech.com> Co-authored-by: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
…the installation package (C++ runtime included) (#119) * example * adaptation for windows installer pack * added guide link * Apply suggestions from code review Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com> * fixed dll detection Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
* [AD-943] Update documentation on limitations. * Update src/markdown/support/odbc-support-and-limitations.md Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com> * [AD-943] Code review improvements. Co-authored-by: andiem-bq <67925459+andiem-bq@users.noreply.github.com>
* added aws logo to the installer * fix identation * fixed merge conflict
* [AD-912] Test if 32-bit and 64-bit artefacts are created. * [AD-912] Set artifact logic when push to develop branch. * [AD-912] Test adding version to artifacts and setting for the library properties. * [AD-912] Propagate ODBC_DRIVER_VERSION to all builds. * [AD-912] Fix 'if' statements with environment variables. * [AD-912] Now source the driver version from the ODBC_DRIVER_VERSION.txt file. * [AD-912] Fix updating the environment in workflow. * [AD-912] Fix updating the environment in workflow. * [AD-912] Fix updating the environment in workflow. * [AD-912] Fixed updating the environment in workflow. * [AD-912] Set the criteria for uploading artifacts to production mode.
* [AD-915] Embed JRE into install. Simplify versioning of JDBC driver. * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Fixed setting the JDBC_DRIVER_VERSION * [AD-915] Attempting to debug Windows 32-bit JDBC installer * [AD-915] Attempting fix to Windows 32-bit JDBC installer * [AD-915] Correct indentation formatting. * [AD-915] Code review improvements. * [AD-915] Temporary enable creating artifacts to get 32-bit installer. * [AD-915] Remove unnecessary "verbose" on jpackage command. * [AD-915] Fixed Platform setting in JDBC installer main.wxs.in * [AD-915] Replace JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Attempt fix of JDK installation with script on Windows. * [AD-915] Increase tracing info for JDK installation with script on Windows. * [AD-915] Change parameter to JDK installer script. * [AD-915] Create JDKs directory, if not exists. * [AD-915] Fix syntax - Create JDKs directory, if not exists. * [AD-915] Fix location - Create JDKs directory, if not exists. * [AD-915] Fix setting of JAVA_HOME environment variable in GitHub workflow. * [AD-915] Get full path of JDKs folder. * [AD-915] Fix Resolve-Path call. * [AD-915] Add path to $JAVA_HOME/bin * [AD-915] Refactor code to use 'jlink' and create a runtime image instead of application for 'jpackage'. * [AD-915] Attempt to build Windows 32-bit installer using 'jpackage'. * [AD-915] Attempt #2 to build Windows 32-bit installer using 'jpackage'. * [AD-915] More clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #2 to fix clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #3 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Attempt #4 to clean-up and make release artifacts smaller/cleaner. * [AD-915] Remove commented unused code. * [AD-915] Fix path to JVM.dll in JDBC installer template. * [AD-915] Set artifacts to be made on push to the develop branch. * [AD-915] Improve naming and version numbers for installer * [AD-915] Remove unused icon file. * [AD-915] Rename a installer resource for better clarity. * [AD-915] Add tracing for JLINK_VERSION. * [AD-915] Fix issue with JLINK_VERSION having more than 3 version components. * [AD-915] Code review changes. * [AD-915] Revert code to create artifacts - so now only on push to develop branch.
* fix SQL_PRCEDURE define * fixing typo
* code coverage test * fixing yml file * testing variable * fixing yml * fixing badge extract * fix extract url * fixing build * adding checkout ref * Commit Code Coverage Badge * adding badge for others platforms * Commit Code Coverage Badge * fix mac and linux build * fix badge dir * Commit Code Coverage Badge * adding git pull before commit badge * removing mkdir * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge * Apply suggestions from code review Co-authored-by: Bruce Irschick <brucei@bitquilltech.com> * fix commit * fix commit badge * Commit Code Coverage Badge * fixing commit badge * adding git folder * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge * Commit Code Coverage Badge Co-authored-by: affonsoBQ <affonsoBQ@users.noreply.github.com> Co-authored-by: Bruce Irschick <brucei@bitquilltech.com>
* [AD-995] Add SECURITY.md page and reference in README.md. * Commit Code Coverage Badge Co-authored-by: birschick-bq <birschick-bq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automate Windows Signing Step for GitHub
Description
Added GitHub step to perform signing
Related Issue
https://bitquill.atlassian.net/browse/AD-1070
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022