Conversation
| "Utils.topology": "Topology: %s", | ||
| "RdsHostListProvider.incorrectDialect": "Dialect needs to be a topology aware dialect.", | ||
| "RdsHostListProvider.suggestedClusterId": "ClusterId '%s' is suggested for url '%s'.", | ||
| "RdsHostListProvider.noClusterId": "No clusterId found. Please ensure clusterId parameter is set to a non-empty string.", |
There was a problem hiding this comment.
I did a little audit of all the messages and here are the ones that are
In code and not in the messages file:
- PluginService.errorIdentifyConnection
- Failover2.unableToConnect
- LimitlessConnectionPlugin.failedToConnectToHost
- RdsHostListProvider.parsedListEmpty
- RdsHostListProvider.invalidPattern.suggestedClusterId
- RdsHostListProvider.clusterInstanceHostPatternNotSupportedForRDSProxy
- RdsHostListProvider.clusterInstanceHostPatternNotSupportedForRdsCustom
Fewer args than %s (literal %s leaks — add missing arg)
Failover.unexpectedReaderRole— %s: 2, args: 1Bgd.stillInProgressTryMethodLater— %s: 2, args: 1MonitorService.monitorClassMismatch— %s: 4, args: 3
-PluginManager.unknownPluginCode— %s: 1, args: 0
More args than %s (extra arg dropped)
AwsSecretsManagerConnectionPlugin.unhandledError— %s: 1, args: 2HostResponseTimeMonitor.interruptedErrorDuringMonitoring— %s: 1, args: 2LimitlessRouterMonitor.errorDuringMonitoringStop— %s: 1, args: 2HostMonitor.detectedWriter— %s: 1, args: 2LimitlessRouterServiceImpl.nullLimitlessRouterMonitor— %s: 0, args: 1ConfigurationProfileBuilder.profileNameRequired— %s: 0, args: 1
In the messages file and not in the code:
AuroraInitialConnectionStrategyPlugin.requireDynamicProvider
Authentication.unsupportedHostname
Bgd.inProgressConnectionClosed
Bgd.interrupted
Bgd.unhandledNetworkError
Bgd.usesVersion
ClientUtils.connectTimeout
ClusterAwareReaderFailoverHandler.failedReaderConnection
ClusterTopologyMonitor.endMonitoring
ClusterTopologyMonitor.errorDuringMonitoring
ClusterTopologyMonitor.startingHostMonitors
ClusterTopologyMonitor.unableToConnect
ClusterTopologyMonitoring.ignoringNewTopologyRequest
ConnectionStringHostListProvider.errorIdentifyConnection
Failover.TransactionResolutionUnknownError
Failover.connectionExplicitlyClosed
Failover.noOperationsAfterConnectionClosed
Failover.strictReaderUnknownHostRole
Failover2.failoverReaderNotConnectedToReader
GlobalDbFailoverPlugin.unableToConnect
HostMonitor.writerIsStale
HostResponseTimeMonitor.stopped
MonitorImpl.startMonitoringTaskNewContext
MonitorImpl.stopMonitoringTaskNewContext
MonitorImpl.stopped
OpenedConnectionTracker.unableToPopulateOpenedConnectionQueue
PluginService.failedToRetrieveHostPort
PluginService.releaseResources
PluginService.requiredBlockingHostListProvider
PluginServiceImpl.failedToRetrieveHostPort
RdsHostListProvider.noClusterId
RdsMultiAzDatabaseDialect.invalidTopology
ReadWriteSplittingPlugin.closingInternalClients
ReadWriteSplittingPlugin.failedToConnectToWriter
StaleDnsHelper.clusterEndpointDns
StaleDnsHelper.writerInetAddress
StaleDnsPlugin.requireDynamicProvider
There was a problem hiding this comment.
Thanks for catching this. Addressed.
Summary
Adds Aurora Global Database (GDB) support to the AWS Advanced NodeJS Wrapper, along with the supporting refactors that make it possible.
Description
New GDB features
Supporting refactors
Docs & CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.