Skip to content

Conversation

@zijun726911
Copy link
Contributor

@zijun726911 zijun726911 commented Oct 13, 2023

What type of PR is this? Fix #435

Referred that PR #264

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 6513732297

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.361%

Totals Coverage Status
Change from base Build 6513019827: 0.0%
Covered Lines: 3950
Relevant Lines: 8708

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 13, 2023

Pull Request Test Coverage Report for Build 6513795831

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.361%

Totals Coverage Status
Change from base Build 6513019827: 0.0%
Covered Lines: 3950
Relevant Lines: 8708

💛 - Coveralls

@solmonk
Copy link
Contributor

solmonk commented Oct 13, 2023

Thanks for working on this, but I think we should not close the referring issue until proper documentation is delivered.

@zijun726911 zijun726911 merged commit f68c970 into main Oct 16, 2023
@mikhail-aws mikhail-aws deleted the cluster-name-env-variable branch November 1, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart failing to install when IMDS is unavailable

4 participants