Skip to content

Add ability to pass CLUSTER_NAME env variable in helm chart #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add ability to pass CLUSTER_NAME env variable in helm chart #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84cb520
Add ability to pass CLUSTER_NAME env variable for helm chart
Oct 13, 2023
3b01adf
address PR comments
Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/deploy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,10 @@ Run through them again for a second cluster to use with the extended example sho
oci://public.ecr.aws/aws-application-networking-k8s/aws-gateway-controller-chart\
--version=v0.0.17 \
--set=serviceAccount.create=false --namespace aws-application-networking-system \
# Region, clusterVpcId, awsAccountId are required for case where IMDS is NOT AVAILABLE, e.g Fargate
# awsRegion, clusterVpcId, clusterName, awsAccountId are required for case where IMDS is NOT AVAILABLE, e.g Fargate, self-managed clusters with IMDS access blocked
--set=awsRegion= \
--set=clusterVpcId= \
--set=clusterName= \
--set=awsAccountId= \

```
Expand Down
2 changes: 2 additions & 0 deletions helm/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ data:
awsRegion: {{ .Values.awsRegion | quote }}
awsAccountId: {{ .Values.awsAccountId | quote }}
clusterVpcId: {{ .Values.clusterVpcId | quote }}
clusterName: {{ .Values.clusterName | quote }}

5 changes: 5 additions & 0 deletions helm/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ spec:
configMapKeyRef:
name: env-config
key: clusterVpcId
- name: CLUSTER_NAME
valueFrom:
configMapKeyRef:
name: env-config
key: clusterName

terminationGracePeriodSeconds: 10
nodeSelector: {{ toYaml .Values.deployment.nodeSelector | nindent 8 }}
Expand Down
1 change: 1 addition & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,4 @@ serviceAccount:
awsRegion:
awsAccountId:
clusterVpcId:
clusterName: