feat(applicationsignals-alpha): introduce Application Signals L2 constructs #32931

bjrara · 2025-01-15T01:51:53Z

Issue # (if applicable)

N/A

Description of changes

This PR adds L2 constructs to simplify the Application Signals enablement process. See aws/aws-cdk-rfcs#672 for more details.

Describe any new or updated permissions being added

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

codecov · 2025-01-15T02:10:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (d42bd90).
Report is 32 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32931   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112

Flag	Coverage Δ
suite.unit	`83.98% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`83.98% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

moelasmar · 2025-01-16T06:17:44Z

@Mergifyio refresh

mergify · 2025-01-16T06:17:49Z

refresh

✅ Pull request refreshed

packages/@aws-cdk/aws-applicationsignals-alpha/.eslintrc.js

packages/@aws-cdk/aws-applicationsignals-alpha/package.json

packages/@aws-cdk/aws-applicationsignals-alpha/README.md

moelasmar · 2025-01-21T03:44:19Z

packages/@aws-cdk/aws-applicationsignals-alpha/lib/enablement/ecs.ts

+      throw new Error('Fargate tasks must deploy CloudWatch Agent as a sidecar container');
+    }
+    if (cloudWatchAgentConfig.enableSidecar) {
+      props.taskDefinition.taskRole.addManagedPolicy(ManagedPolicy.fromAwsManagedPolicyName('CloudWatchAgentServerPolicy'));


using this Managed policy violates the Apply least-privilege permissions rule of the security best practices, since as defined here, this managed policy enable multiple actions for * resources. It will be petter to add a new Policy, and add the specific resources that you need these actions to be allowed on them.

packages/@aws-cdk/aws-applicationsignals-alpha/lib/enablement/ecs.ts

packages/@aws-cdk/aws-applicationsignals-alpha/package.json

Pull request has been modified.

aws-cdk-automation · 2025-02-13T00:11:29Z

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

Resume work on the PR
OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 7 days if no action is taken.

aws-cdk-automation · 2025-02-21T00:11:15Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

github-actions · 2025-02-21T00:11:38Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

moelasmar · 2025-04-14T07:24:11Z

thanks @bjrara .. I approved this PR, but I added do not merge label since it needs a security review

Pull request has been modified.

bjrara · 2025-04-14T17:02:56Z

thanks @bjrara .. I approved this PR, but I added do not merge label since it needs a security review

ack! Will keep an eye on this PR in case any additional comments. Thank you!

Pull request has been modified.

moelasmar

thanks @bjrara for your contribution

mergify · 2025-04-23T09:19:31Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-04-23T09:49:51Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 9fb8d5b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-04-23T09:50:15Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-04-23T09:50:34Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 15, 2025

aws-cdk-automation requested a review from a team January 15, 2025 01:52

aws-cdk-automation previously requested changes Jan 15, 2025

View reviewed changes

bjrara changed the title ~~feat(aws-applicationsignals-alpha): introduce Application Signals L2 constructs~~ feat(applicationsignals-alpha): introduce Application Signals L2 constructs Jan 15, 2025

bjrara force-pushed the application-signals branch 5 times, most recently from 921a486 to 43766a8 Compare January 15, 2025 04:42

aws deleted a comment from aws-cdk-automation Jan 15, 2025

bjrara force-pushed the application-signals branch 2 times, most recently from 652b1da to 021dcf9 Compare January 20, 2025 18:16

moelasmar previously requested changes Jan 21, 2025

View reviewed changes

bjrara force-pushed the application-signals branch from 021dcf9 to 6a0863c Compare January 22, 2025 04:19

bjrara force-pushed the application-signals branch 3 times, most recently from 5a2f537 to f8b8fa2 Compare January 22, 2025 07:34

github-actions bot mentioned this pull request Feb 1, 2025

Monthly PR metrics report #33266

Closed

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 21, 2025

aws-cdk-automation closed this Feb 21, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 14, 2025

moelasmar previously approved these changes Apr 14, 2025

View reviewed changes

bjrara force-pushed the application-signals branch from d42bd90 to 1060150 Compare April 22, 2025 22:46

bjrara force-pushed the application-signals branch from 1060150 to 6261233 Compare April 22, 2025 23:00

bjrara added 7 commits April 22, 2025 16:02

Add application signals enablement L2

0f8d552

Address comments

4c76d60

Update daemon test

facbf08

Address additional comments

8826d8b

Update readme and tests

2dd90b9

Add more integration tests

0bb4a6c

Update readme

bd040aa

bjrara force-pushed the application-signals branch 2 times, most recently from 225a331 to 9341e5b Compare April 22, 2025 23:08

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 22, 2025

Update README, add warning message

6185539

bjrara force-pushed the application-signals branch from 9341e5b to 6185539 Compare April 23, 2025 03:55

moelasmar approved these changes Apr 23, 2025

View reviewed changes

moelasmar removed the pr/do-not-merge This PR should not be merged at this time. label Apr 23, 2025

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 23, 2025

Merge branch 'main' into application-signals

9fb8d5b

mergify bot merged commit e7a6e14 into aws:main Apr 23, 2025
13 of 15 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2025

feat(applicationsignals-alpha): introduce Application Signals L2 constructs #32931

feat(applicationsignals-alpha): introduce Application Signals L2 constructs #32931

Conversation

bjrara commented Jan 15, 2025

Issue # (if applicable)

Description of changes

Describe any new or updated permissions being added

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

moelasmar commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Jan 16, 2025

✅ Pull request refreshed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moelasmar Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aws-cdk-automation commented Feb 13, 2025

Uh oh!

aws-cdk-automation commented Feb 21, 2025

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

moelasmar commented Apr 14, 2025

Uh oh!

bjrara commented Apr 14, 2025

Uh oh!

moelasmar left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 23, 2025

Uh oh!

aws-cdk-automation commented Apr 23, 2025

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Apr 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 15, 2025 •

edited

Loading

moelasmar commented Jan 16, 2025 •

edited

Loading