chore: using pr_target and separating collect and upload #34247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
added
the
pr/needs-maintainer-review
godwingrs22
reviewed
Apr 24, 2025
Member
godwingrs22
left a comment
godwingrs22
left a comment
There was a problem hiding this comment.
Thanks @QuantumNeuralCoder for fixing this issue. LGTM. Left a comment for my understanding. Would be good to approve if there is no concern from the security team.
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
QuantumNeuralCoder
added
the
pr/do-not-merge
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2025
### Issue # (if applicable) same as #34247 #34211 Closes #<issue number here>. ### Reason for this change ### Description of changes ### Describe any new or updated permissions being added Codecov is split into `collect` with lesser permissions and `upload` with escalated permissions. ### Description of how you validated changes ### Checklist - [ x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
obraafo
pushed a commit
to obraafo/aws-cdk
that referenced
this pull request
May 14, 2025
### Issue # (if applicable) same as aws#34247 aws#34211 Closes #<issue number here>. ### Reason for this change ### Description of changes ### Describe any new or updated permissions being added Codecov is split into `collect` with lesser permissions and `upload` with escalated permissions. ### Description of how you validated changes ### Checklist - [ x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
maharajhaider
pushed a commit
to maharajhaider/aws-cdk
that referenced
this pull request
May 14, 2025
### Issue # (if applicable) same as aws#34247 aws#34211 Closes #<issue number here>. ### Reason for this change ### Description of changes ### Describe any new or updated permissions being added Codecov is split into `collect` with lesser permissions and `upload` with escalated permissions. ### Description of how you validated changes ### Checklist - [ x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #.
Reason for this change
Replacing #34211
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license