fix: recent change to IAlarmAction breaks too many implementors#36695
fix: recent change to IAlarmAction breaks too many implementors#36695mergify[bot] merged 5 commits intomainfrom
Conversation
In a recent change we changed the signature of `IAlarmAction`:
```ts
export interface IAlarmAction {
- bind(scope: Construct, alarm: IAlarm): AlarmActionConfig;
+ bind(scope: Construct, alarm: IAlarmRef): AlarmActionConfig;
}
```
This breaks too many current implementors of this interface, so we
are reverting the change.
rix0rrr
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 78df1c1 This pull request spent 39 minutes 26 seconds in the queue, including 39 minutes 12 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
In a recent change we changed the signature of
IAlarmAction:This breaks too many current implementors of this interface, so we are reverting the change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license