chore: linter rule requires L2 interfaces to extend reference interface #36696
Conversation
This requires that `IBucket extends IBucketRef`, etc.
rix0rrr
force-pushed
the
huijbers/force-extends
branch
from
9f944ca to
ea8e187
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
| eval: e => { | ||
| const bases = e.ctx.getInterfaces(true); | ||
|
|
||
| e.assert(bases.some(b => b.name.endsWith('Ref')), e.ctx.fqn); |
There was a problem hiding this comment.
Not sure how strict we want to be, but this rule would allow IBucket to extend SomeNonsenseRef while not extending IBucketRef.
There was a problem hiding this comment.
I understand. "Close enough for government work" was my take. This is not to prevent cheating the system, it is to prevent forgetting.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 7717128 This pull request spent 59 minutes 43 seconds in the queue, including 42 minutes 15 seconds running CI. Required conditions to merge
|
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
3 participants
This requires that
IBucket extends IBucketRef, etc.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license