Skip to content

ci(mergify): skip integration deployment test if PR is in merge queue#36699

Merged
mergify[bot] merged 2 commits intomainfrom
mergify/Abogical/I3dc22728867ca82134bfadd5d7ce03d8370ee3ab
Jan 20, 2026
Merged

ci(mergify): skip integration deployment test if PR is in merge queue#36699
mergify[bot] merged 2 commits intomainfrom
mergify/Abogical/I3dc22728867ca82134bfadd5d7ce03d8370ee3ab

Conversation

@Abogical
Copy link
Member

@Abogical Abogical commented Jan 15, 2026

If a PR had a new merge commit from main before it was about merged to main, the integration test deployment workflow was triggered and waited for user input to start the workflow. This blocked merge queues unnecessarily.

This PR disables this conditions only if the PR is in the merge queue.

Note that by default merge_conditions is the same as queue_conditions if its not specified. We specify them in this PR without the integ test workflow check, so it would be skipped during merge check.

This change has been made by @Abogical from the Mergify config editor.

Signed-off-by: A. Abdel-Rahman <null>
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2026 13:49
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK p2 labels Jan 15, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 15, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 📃 Configuration Change Requirements

Wonderful, this rule succeeded.

Mergify configuration change

  • check-success = Configuration changed

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Abogical Abogical changed the title ci(Mergify): configuration update ci(Mergify): skip integration deployment test if PR is in merge queue Jan 15, 2026
@Abogical Abogical changed the title ci(Mergify): skip integration deployment test if PR is in merge queue ci(mergify): skip integration deployment test if PR is in merge queue Jan 15, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 15, 2026 13:55

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@kumvprat
Copy link
Contributor

We should consider revert scenarios : What happens if we need to revert this ? Will it bypass the mergify queue itself ?

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 15, 2026
@Abogical
Copy link
Member Author

@kumvprat I think you can just a regular Github merge to override mergify.

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2026

Merge Queue Status

✅ The pull request has been merged at 72d3029

This pull request spent 42 minutes 49 seconds in the queue, including 30 minutes 32 seconds running CI.
The checks were run in-place.

Required conditions to merge

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 20, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 77baea1 into main Jan 20, 2026
18 of 19 checks passed
@mergify mergify bot deleted the mergify/Abogical/I3dc22728867ca82134bfadd5d7ce03d8370ee3ab branch January 20, 2026 11:30
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants