fix(core): tree.json unintentionally includes telemetry metadata#36748
Merged
mergify[bot] merged 3 commits intomainfrom Jan 22, 2026
Merged
fix(core): tree.json unintentionally includes telemetry metadata#36748mergify[bot] merged 3 commits intomainfrom
mergify[bot] merged 3 commits intomainfrom
Conversation
aws-cdk-automation
previously requested changes
Jan 21, 2026
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
dbc105c to
d4e926a
Compare
3b5a2f0 to
f4d70c0
Compare
f4d70c0 to
3e23d39
Compare
mrgrain
commented
Jan 21, 2026
Contributor
Author
There was a problem hiding this comment.
split-out from runtime-info.test.ts
mrgrain
commented
Jan 21, 2026
Contributor
Author
There was a problem hiding this comment.
adjusted and moved into metadata-resource.test.ts
rix0rrr
approved these changes
Jan 22, 2026
Contributor
Author
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status✅ The pull request has been merged at 039741f This pull request spent 6 seconds in the queue, with no time running CI. Required conditions to merge
|
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
ConstructInfointerface is used both for telemetry analytics (sent to AWS) and for thetree.jsonoutput. Previously, telemetry metadata was being added toConstructInfo, which caused it to leak intotree.json- a file that should only contain basic construct information (fqn and version).Description of changes
This PR separates the concerns by:
ConstructInfoclean with onlyfqnandversion- this is the public contract fortree.jsonConstructAnalyticsinterface that extendsConstructInfowith optionaltelemetryMetadataruntime-info.tsto a newstack-metadata.tsfiletree.jsonThe feature flag
ENABLE_ADDITIONAL_METADATA_COLLECTIONcontinues to control whether telemetry metadata is included in the analytics sent to AWS.Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license