Skip to content

chore: assembly-related code has moved from cx-api#36770

Merged
mergify[bot] merged 10 commits intomainfrom
huijbers/strip-cx-api
Feb 5, 2026
Merged

chore: assembly-related code has moved from cx-api#36770
mergify[bot] merged 10 commits intomainfrom
huijbers/strip-cx-api

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Jan 22, 2026

We have recently moved a good chunk of code from cx-api over to @aws-cdk/cloud-assembly-api. Remove the code here in favor of re-exports for backwards compatibility.

In order to pass the jsii build, we need to pull the following trick:

  • Re-declare the types that we use in this assembly here (declare class ...), so to jsii it looks like all the classes are still defined in the same location they were before.
  • Copy the implementation from the upstream library, so the implementation stays centralized in a single place.

Introduce functions to convert between the private and public variants of these types; we will use the private types for implementation, and the public types in the API.

Because the (upstream) API can only ever grow, the class types declared in here are structural supertypes, so the casting we need to do to make this work is valid.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We have recently moved a good chunk of code from `cx-api` over to
`@aws-cdk/cloud-assembly-api`. Remove the code here in favor of
re-exports for backwards compatibility.
@rix0rrr rix0rrr requested review from a team January 22, 2026 13:03
@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2026 13:03
@github-actions github-actions bot added the p2 label Jan 22, 2026
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 22, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 5, 2026

Merge Queue Status

✅ The pull request has been merged at 18ee94b

This pull request spent 30 minutes 36 seconds in the queue, including 30 minutes 24 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 5, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2cf8cbc into main Feb 5, 2026
17 of 18 checks passed
@mergify mergify bot deleted the huijbers/strip-cx-api branch February 5, 2026 10:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants