fix: prevent prototype pollution in 2 APIs#37453
Merged
Merged
Conversation
aws-cdk-automation
previously requested changes
Mar 31, 2026
mrgrain
approved these changes
Mar 31, 2026
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-further-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
rix0rrr
changed the title
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 1 hour 14 minutes 55 seconds in the queue, including 30 minutes 16 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent prototype pollution in a couple of APIs:
Fact.register()cfnResource.addOverride()Prototype pollution is not a realistic attack on CDK, since values never come from untrusted sources. Nevertheless, the presence of possible prototype pollution sites makes for a fertile ground for security reports that we then have to look into.
This PR replaces #37408, in which I got bamboozled by Kiro into identifying a lot of non-vulnerable locations.
Fix a couple of sites here, and also add tests to confirm that a number of other sites are already protected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license