feat(core): add source tracing for L1 construct property mutations#37543
Merged
mergify[bot] merged 2 commits intomainfrom Apr 7, 2026
Merged
feat(core): add source tracing for L1 construct property mutations#37543mergify[bot] merged 2 commits intomainfrom
mergify[bot] merged 2 commits intomainfrom
Conversation
Add `traceProperty` utility that records metadata with stack traces on CfnResource property setters when CDK_DEBUG=1 is enabled. Update spec2cdk code generation to emit getter/setter pairs (instead of plain fields) for mutable L1 properties, calling traceProperty in each setter to capture the call site. The main difference in comparison with the previous attempt is that this time we are using the backing property (`this._propertyName`) instead of the getter (`this.propertyName`) in `cfnProperties()`. To make sure this regression doesn't happen again, there is a new test that verifies that we can create an L1 without deprecated properties.
aws-cdk-automation
previously requested changes
Apr 7, 2026
otaviomacedo
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
rix0rrr
approved these changes
Apr 7, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 29 minutes 57 seconds in the queue, including 28 minutes 59 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-roll of #37285.
Add
tracePropertyutility that records metadata with stack traces on CfnResource property setters when CDK_DEBUG=1 is enabled.Update spec2cdk code generation to emit getter/setter pairs (instead of plain fields) for mutable L1 properties, calling traceProperty in each setter to capture the call site.
The main difference in comparison with the previous attempt is that this time we are using the backing property (
this._propertyName) instead of the getter (this.propertyName) incfnProperties(). To make sure this regression doesn't happen again, there is a new test that verifies that we can create an L1 without deprecated properties.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license