Skip to content

feat(mediapackagev2-alpha): add OAC integration between CloudFront and MediaPackageV2#37701

Open
jamiepmullan wants to merge 5 commits intoaws:mainfrom
jamiepmullan:feat/mediapackage-cloudfront-oac-integration
Open

feat(mediapackagev2-alpha): add OAC integration between CloudFront and MediaPackageV2#37701
jamiepmullan wants to merge 5 commits intoaws:mainfrom
jamiepmullan:feat/mediapackage-cloudfront-oac-integration

Conversation

@jamiepmullan
Copy link
Copy Markdown
Contributor

@jamiepmullan jamiepmullan commented Apr 27, 2026

Issue # (if applicable)

Closes #.
aws/aws-cdk-rfcs#910

Reason for this change

Description of changes

Complete the integration between CloudFront and MediaPackageV2 to help a user to wire this up easier with less code! Provide same experience compared to other origins in cloudfront-origins.

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions Bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Apr 27, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team April 27, 2026 11:24
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.
To suppress a specific rule, see Suppressing Rules.


TestsPassed ✅SkippedFailed
Security Guardian Results48 ran48 passed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.
To suppress a specific rule, see Suppressing Rules.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates48 ran48 passed
TestResult
No test annotations available

@jamiepmullan
Copy link
Copy Markdown
Contributor Author

Clarification Request

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Apr 27, 2026
@aws-cdk-automation aws-cdk-automation added the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Apr 27, 2026
@jamiepmullan jamiepmullan marked this pull request as ready for review April 27, 2026 14:05
@alvazjor alvazjor self-assigned this Apr 27, 2026
Comment thread packages/@aws-cdk/aws-mediapackagev2-alpha/lib/cloudfront-origin.ts Outdated
Comment thread packages/aws-cdk-lib/aws-cloudfront/lib/origin-access-control.ts Outdated
@alvazjor alvazjor removed the pr/needs-further-review PR requires additional review from our team specialists due to the scope or complexity of changes. label Apr 28, 2026
@alvazjor alvazjor changed the title feat(mediapackagev2+cloudfront): add OAC integration between CloudFront and MediaPackageV2 feat(mediapackagev2-alpha): add OAC integration between CloudFront and MediaPackageV2 Apr 28, 2026
@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself April 28, 2026 12:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 28, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 28, 2026

Merge Queue Status

  • Entered queue2026-04-28 12:11 UTC · Rule: default-squash
  • Checks started · in-place
  • 🚫 Left the queue2026-04-28 12:17 UTC · at 446be607912147de8b9d37b4a81d86f62a07736d

This pull request spent 5 minutes 48 seconds in the queue, with no time running CI.

Waiting for any of:
  • check-neutral = build
  • check-skipped = build
  • check-success = build
All conditions

Reason

Pull request #37701 has been dequeued

The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • -label~=(blocked|do-not-merge|agent-docs-review-needed|no-squash|two-approvers|priority-pr)
  • check-success=build
  • check-success=validate-pr
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue rule default-squash]
      • -label~=(blocked|do-not-merge|agent-docs-review-needed|no-squash|priority-pr)
      • check-success=build
      • check-success=validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = validate-pr
        • check-skipped = validate-pr
        • check-success = validate-pr
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build
        • check-skipped = build
        • check-success = build

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@alvazjor alvazjor added the pr/do-not-merge This PR should not be merged at this time. label Apr 28, 2026
@alvazjor
Copy link
Copy Markdown
Contributor

alvazjor commented Apr 28, 2026

This PR will be merged once aws/aws-cdk-rfcs#910 gets merge. The RFC is already approved and in final comments period, if by May 4th there is no additional comments, we can merge the RFC and this PR too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/do-not-merge This PR should not be merged at this time. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants