Skip to content

fix(custom-resource-handlers): deployment fails when parameter already exists#37852

Merged
mergify[bot] merged 2 commits into
mainfrom
otaviom/overwrite-param
May 13, 2026
Merged

fix(custom-resource-handlers): deployment fails when parameter already exists#37852
mergify[bot] merged 2 commits into
mainfrom
otaviom/overwrite-param

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo commented May 12, 2026

In the upgrade to 2.253.0, there is a scenario in which the SSM parameters used by the custom resources are not deleted, even though the custom resources themselves are. When upgrading to 2.253.1, the custom resources are recreated, and the writer tries to put the parameter again. But, since it's not passing the Overwrite: true parameter, SSM rejects the request, and the deployment fails.

Add Overwrite: true to the putParameter call.

Fixes #37845.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions Bot added bug This issue is a bug. p0 labels May 12, 2026
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label May 12, 2026
@mergify mergify Bot temporarily deployed to automation May 12, 2026 17:29 Inactive
@mergify mergify Bot temporarily deployed to automation May 12, 2026 17:29 Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

⚠️ This pull request description does not follow the correct template structure.

PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like Closes #123 in the Issue section. If no existing issue matches your change, create one first.

Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@otaviomacedo otaviomacedo marked this pull request as ready for review May 12, 2026 17:39
@otaviomacedo otaviomacedo requested a review from rix0rrr May 12, 2026 17:50
Copy link
Copy Markdown
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otaviomacedo otaviomacedo added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label May 13, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 13, 2026 06:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 13, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 13, 2026

Merge Queue Status

  • Entered queue2026-05-13 06:12 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-05-13 06:59 UTC · at 8641c870ecd24edb3c40d1cee7fc76dc084131ee · squash

This pull request spent 47 minutes 13 seconds in the queue, including 46 minutes 56 seconds running CI.

Required conditions to merge

@mergify mergify Bot temporarily deployed to automation May 13, 2026 06:12 Inactive
@mergify mergify Bot temporarily deployed to automation May 13, 2026 06:12 Inactive
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 13, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 025c38c into main May 13, 2026
18 of 19 checks passed
@mergify mergify Bot deleted the otaviom/overwrite-param branch May 13, 2026 06:59
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p0 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom::CrossRegionExportWriter fails with ParameterAlreadyExists after upgrading from 2.253.0 to 2.253.1

3 participants