fix(core): cached Lazys use the Box API internally#37889
Merged
Conversation
mrgrain
changed the title
Contributor
|
👋 It looks like your PR description follows the template but is missing a valid issue number in the first section. PRs without a linked issue will receive lower priority for review and merging. Please update the description to include a reference like |
mrgrain
changed the title
Lazy now uses the Box API internally
aws-cdk-automation
previously requested changes
May 15, 2026
mrgrain
added
pr-linter/exempt-readme
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mrgrain
changed the title
Lazy now uses the Box API internallyLazys now use the Box API internally
mrgrain
changed the title
Lazys now use the Box API internallyLazys use the Box API internally
mrgrain
force-pushed
the
mrgrain/refactor/core/lazy-extends-box
branch
from
8565bff to
7d83d36
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
otaviomacedo
approved these changes
May 15, 2026
otaviomacedo
added
the
pr/do-not-merge
aws-cdk-automation
removed
the
pr/needs-maintainer-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
Refactor LazyBase to extend State from the Box API, making all Lazy tokens pass Box.isBox(). This enables PropertyAssignmentMetadataWriter to detect Lazy tokens and allows Lazy values to participate in the Box derive/combine ecosystem. Export State and BaseReadableBox from box.ts. Add Box.empty() factory. Add tests verifying Lazy tokens are boxes with correct resolve, derive, and caching behavior.
mrgrain
force-pushed
the
mrgrain/refactor/core/lazy-extends-box
branch
from
7d83d36 to
96ba2cd
Compare
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
Merge Queue Status
This pull request spent 1 hour 21 minutes 24 seconds in the queue, including 39 minutes 30 seconds running CI. Required conditions to merge
|
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
We don't want multiple deferred value APIs that behave differently. With this change,
Lazyacts as a backwards-compatible user-facing front, but internally it's all Box API. One resolution mechanism, one set of behaviors.Description of changes
Introduces
LazyBox, aReadonlyStatewrapper that makes cached Lazy tokens participate in the Box ecosystem. Cached Lazy methods (Lazy.string(),Lazy.number(),Lazy.list(),Lazy.any()) now return aLazyBoxthat passesBox.isBox()and supportsderive()andgetStackTraces().Uncached Lazy methods remain unchanged — they depend on resolution context and cannot be boxes (at least for now).
Splits
ReadonlyStateout ofStateinbox.tsto provide an immutable base forLazyBox.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added tests in
boxes.test.tsverifying that cached Lazy variants are boxes and uncached variants are not. Tests coverBox.isBox(),resolve(),derive(), and caching semantics. All existing tests (including nested-stack) continue to pass.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license