Error on empty CA bundle value - #10497
Merged
Merged
Conversation
alexgromero
force-pushed
the
fix/empty-ca-bundle-value
branch
from
July 17, 2026 22:39
1393636 to
bb8054f
Compare
AndrewAsseily
left a comment
AndrewAsseily
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Just left a small nit
| ) | ||
|
|
||
| def _validate_verify_value(self, verify): | ||
| if isinstance(verify, str) and not verify: |
Contributor
There was a problem hiding this comment.
Nit: not verify is only true for ''. not verify.strip() is true for '' and any all-whitespace strings (' ', '\t', '\n') if we want an InvalidConfigError for those too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The CLI now errors when a CA bundle value (
--ca-bundle, theca_bundleprofile setting,AWS_CA_BUNDLE, orREQUESTS_CA_BUNDLE) resolves to an empty string.An empty string is not a valid value for these settings, which are defined as paths to a CA bundle.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.