Skip to content

fix(assetlibrary): properly quote escaped characters in cloudformation #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(assetlibrary): properly quote escaped characters in cloudformation #185

merged 2 commits into from
Feb 8, 2024

Conversation

@aaronatbissell
Copy link
Contributor

@aaronatbissell aaronatbissell commented Jan 24, 2024

Description

Fixes #183

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (existing code being refactored)
  • This change includes a documentation update

Submission Checklist

  • CI dry-run passing
  • Integration tests passing locally
  • Change logs generated
Additional Notes:

@ts-amz ts-amz merged commit f89da46 into aws:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ts-amz ts-amz ts-amz approved these changes

@pcozzi pcozzi pcozzi approved these changes

+1 more reviewer

@aalaabed aalaabed aalaabed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DBInstanceType AllowedPattern requires double quotes

4 participants

@aaronatbissell @ts-amz @pcozzi @aalaabed